Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(language-core): correct type narrowing from script to template #4689

Merged
merged 5 commits into from
Aug 25, 2024
Merged

fix(language-core): correct type narrowing from script to template #4689

merged 5 commits into from
Aug 25, 2024

Conversation

KazariEX
Copy link
Collaborator

fix #4391

@KazariEX KazariEX changed the title fix(language-core): correct type narrowing from setup to template fix(language-core): correct type narrowing from script to template Aug 13, 2024
@pkg-pr-new pkg.pr.new
Copy link

pkg-pr-new bot commented Aug 25, 2024 •
edited
Loading

commit: 195d735

vue-component-meta

pnpm add https://pkg.pr.new/vuejs/language-tools/vue-component-meta@4689

vue-component-type-helpers

pnpm add https://pkg.pr.new/vuejs/language-tools/vue-component-type-helpers@4689

@vue/language-core

pnpm add https://pkg.pr.new/vuejs/language-tools/@vue/language-core@4689

@vue/language-plugin-pug

pnpm add https://pkg.pr.new/vuejs/language-tools/@vue/language-plugin-pug@4689

@vue/language-server

pnpm add https://pkg.pr.new/vuejs/language-tools/@vue/language-server@4689

@vue/language-service

pnpm add https://pkg.pr.new/vuejs/language-tools/@vue/language-service@4689

vue-tsc

pnpm add https://pkg.pr.new/vuejs/language-tools/vue-tsc@4689

@vue/typescript-plugin

pnpm add https://pkg.pr.new/vuejs/language-tools/@vue/typescript-plugin@4689

Open in Stackblitz

@johnsoncodehk
Copy link
Member

LGTM, thanks!

@johnsoncodehk johnsoncodehk merged commit fc22bf7 into vuejs:master Aug 25, 2024
5 checks passed
@KazariEX KazariEX deleted the fix/issue-4391 branch August 26, 2024 03:17
@mcsaur mcsaur mentioned this pull request Sep 20, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Type assertions in setup are not narrowed in template
2 participants
@KazariEX @johnsoncodehk