Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(define-macros-order): skip TSModuleDeclaration statements #2593

Merged
merged 1 commit into from
Nov 11, 2024
Merged

fix(define-macros-order): skip TSModuleDeclaration statements #2593

merged 1 commit into from
Nov 11, 2024

Conversation

waynzh
Copy link
Member

@waynzh waynzh commented Nov 2, 2024

fix #2590

FloEdelmann
FloEdelmann approved these changes Nov 4, 2024
View reviewed changes
Copy link
Member

@FloEdelmann FloEdelmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect, thank you!

@FloEdelmann FloEdelmann requested a review from ota-meshi November 4, 2024 08:04
ota-meshi
ota-meshi approved these changes Nov 11, 2024
View reviewed changes
Copy link
Member

@ota-meshi ota-meshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you!

@ota-meshi ota-meshi merged commit 4729a3b into vuejs:master Nov 11, 2024
18 checks passed
@waynzh waynzh deleted the fix/check-module-declaration branch November 11, 2024 04:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ota-meshi ota-meshi ota-meshi approved these changes

@FloEdelmann FloEdelmann FloEdelmann approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

define-macros-order: should ignore declare TypeScript declarations along with type definitions
3 participants
@waynzh @FloEdelmann @ota-meshi