Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

define-macros-order: should ignore declare TypeScript declarations along with type definitions #2590

Closed
2 tasks done
andreww2012 opened this issue Nov 1, 2024 · 0 comments · Fixed by #2593
Closed
2 tasks done

Comments

@andreww2012
Copy link

andreww2012 commented Nov 1, 2024

Checklist

  • I have tried restarting my IDE and the issue persists.
  • I have read the FAQ and my problem is not listed.

Tell us about your environment

  • ESLint version: 9.13.0
  • eslint-plugin-vue version: 9.30.3
  • Vue version: 3.5.12
  • Node version:
  • Operating System:

What did you do?

Since declare TypeScript declarations only exist at compile time, I think they should be allowed to be placed before macros along with type definitions, meaning that the following code should not be reported:

<script setup lang="ts">
declare global {};

defineProps(/* ... */)
defineEmits(/* ... */)
</script>

Test on the rule page

What did you expect to happen?

What actually happened?

Repository to reproduce this issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant