Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(compiler-core): initialize isProp.exp with arg.loc instead of isProp.loc #11547

Merged
merged 1 commit into from
Aug 8, 2024
Merged

fix(compiler-core): initialize isProp.exp with arg.loc instead of isProp.loc #11547

merged 1 commit into from
Aug 8, 2024

Conversation

KazariEX
Copy link
Contributor

@KazariEX KazariEX commented Aug 7, 2024 •
edited by edison1105
Loading

122fde0b1e904c2efb3bb26ab7a9832d

align with

core/packages/compiler-core/src/transforms/vBind.ts

Line 106 in 29425df

dir.exp = createSimpleExpression(propName, false, arg.loc)

@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 7, 2024

Size Report

Bundles

File Size Gzip Brotli
runtime-dom.global.prod.js 90.2 kB 34.6 kB (+3 B) 31.2 kB (+4 B)
vue.global.prod.js 147 kB (+4 B) 54.1 kB (+1 B) 48.2 kB (+23 B)

Usages

Name Size Gzip Brotli
createApp 49.7 kB 19.5 kB 17.8 kB
createSSRApp 53.2 kB 21 kB 19.1 kB
defineCustomElement 51.9 kB 20.2 kB 18.5 kB
overall 63.2 kB 24.5 kB 22.3 kB

@KazariEX KazariEX mentioned this pull request Aug 7, 2024
Merged
@KazariEX KazariEX changed the title fix(compiler-core): initial isProp.exp with arg.loc instead of isProp.loc fix(compiler-core): initialize isProp.exp with arg.loc instead of isProp.loc Aug 7, 2024
@yyx990803 yyx990803 merged commit 236fb7a into vuejs:main Aug 8, 2024
11 checks passed
@KazariEX KazariEX deleted the fix/isProp.exp branch August 8, 2024 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
easy to merge ready to merge The PR is ready to be merged. scope: compiler
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@KazariEX @yyx990803 @edison1105