Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated bundle sizes #603

Merged
merged 2 commits into from
Mar 26, 2019
Merged

Updated bundle sizes #603

merged 2 commits into from
Mar 26, 2019

Conversation

okydk
Copy link
Contributor

@okydk okydk commented Mar 26, 2019

The current sizes are very misleading - the core is almost 4 times bigger than advertised.

okydk added 2 commits March 26, 2019 13:07
The current sizes are very misleading - the core is almost 4 times bigger than advertised.
@coveralls
Copy link

Coverage Status

Coverage remained the same at 89.979% when pulling 6c5af99 on okydk:patch-1 into 62d4a7e on vue-generators:master.

@coveralls
Copy link

coveralls commented Mar 26, 2019

Coverage Status

Coverage remained the same at 89.979% when pulling cdf6f93 on okydk:patch-1 into 62d4a7e on vue-generators:master.

@zoul0813
Copy link
Member

Any chance you can also submit these changes to the doc repo for gitbooks?

@okydk
Copy link
Contributor Author

okydk commented Mar 26, 2019

I don't think bundle sizes are mentioned in gitbooks?

@zoul0813
Copy link
Member

The README for gitbooks should be a duplicate copy of the projects main README. I may have removed the bundle sizes from it recently for the same reason you updated them here.

If it’s not there, no big deal...

@zoul0813 zoul0813 merged commit 721a4ee into vue-generators:master Mar 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants