Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added optional field property debounceValidateTime which works at t… #572

Conversation

zoul0813
Copy link
Member

…he field level, allowing individual fields to be debounced as opposed to the entire schema. works the same as formOptions.debounceValidateTime

  • Please check if the PR fulfills these requirements
  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
    feature
  • What is the current behavior? (You can also link to an open issue here)
    Fields do not have individual 'debounce' logic for validation, the schema does however.
  • What is the new behavior (if this is a feature change)?
    Fields can now have their own debounced time set, allowing the developer to change the debounce delay at the field level.
  • Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
    No - this should be backwards compatible with the existing debounceValidateTime formOption and just extends it.
  • Other information:

GitBook docs were updated to add the validateDebounceTime formOption, as well as reference this new feature.

I also removed the references to this.$parent and updated it to use this.formOptions instead, so this feature should not be affected by Vue hierarchy changes in the future.

The feature defaults to using the field schema, and falls back to the formOptions option with a default of 0 (no delay).

…he field level, allowing individual fields to be debounced as opposed to the entire schema. works the same as `formOptions.debounceValidateTime`
@zoul0813 zoul0813 self-assigned this Dec 21, 2018
…g updated, the `this.$parent.options` reference was required here ... but it does work properly when using the fields client-side, so it's an issue with how the test is defined and not with how the component is written.
@coveralls
Copy link

Coverage Status

Coverage remained the same at 89.979% when pulling 8c1f462 on zoul0813:feature/debounced-validation-field-property into 9f4c72a on vue-generators:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage remained the same at 89.979% when pulling 8c1f462 on zoul0813:feature/debounced-validation-field-property into 9f4c72a on vue-generators:master.

@zoul0813 zoul0813 merged commit b0d681d into vue-generators:master Feb 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants