Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixes an issue with fieldPikaday modifying the field schema and attac… #562

Merged
merged 2 commits into from
Dec 14, 2018
Merged

fixes an issue with fieldPikaday modifying the field schema and attac… #562

merged 2 commits into from
Dec 14, 2018

Conversation

zoul0813
Copy link
Member

…hing this.$el to it, the pikadayOptions are now stored as this.options and created with defaults({}, this.schema.pikadayOptions, {...}) to prevent this

  • Please check if the PR fulfills these requirements
  • The commit message follows our guidelines
  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
    Bug Fix
  • What is the current behavior? (You can also link to an open issue here)
    fieldPikaday modifies the fields schema by using lodash's defaults
  • What is the new behavior (if this is a feature change)?
    fieldPikaday now stores the modified options as this.options without modifying the field's schema
  • Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
    No, it should not

@zoul0813
fixes an issue with fieldPikaday modifying the field schema and attac…
2024204 
…hing `this.$el` to it, the pikadayOptions are now stored as `this.options` and created with `defaults({}, this.schema.pikadayOptions, {...})` to prevent this
@coveralls
Copy link

Coverage Status

Coverage remained the same at 89.916% when pulling 2024204 on zoul0813:feature/561-pikaday into a484031 on vue-generators:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage remained the same at 89.916% when pulling 2024204 on zoul0813:feature/561-pikaday into a484031 on vue-generators:master.

@coveralls
Copy link

coveralls commented Dec 13, 2018 •
edited
Loading

Coverage Status

Coverage remained the same at 89.916% when pulling b3a1010 on zoul0813:feature/561-pikaday into a484031 on vue-generators:master.

@zoul0813 zoul0813 merged commit fcf2897 into vue-generators:master Dec 14, 2018
@zoul0813 zoul0813 deleted the feature/561-pikaday branch December 14, 2018 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lionel-bijaoui lionel-bijaoui Awaiting requested review from lionel-bijaoui

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Pikaday field error 'Converting circular structure to JSON' when the 'pikadayOptions' property is used
2 participants
@zoul0813 @coveralls