Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added "type" attribute to inside buttons schema, defaults to "button"… #558

Merged
merged 2 commits into from
Dec 14, 2018
Merged

added "type" attribute to inside buttons schema, defaults to "button"… #558

merged 2 commits into from
Dec 14, 2018

Conversation

zoul0813
Copy link
Member

… when one is not provided

  • Please check if the PR fulfills these requirements
  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
    Introduces a "type" attribute to "inside buttons" and defaults to "button" when not provided
  • What is the current behavior? (You can also link to an open issue here)
    User can not set the "type" of an inside button
  • What is the new behavior (if this is a feature change)?
    User can set the "type" of an inside button
  • Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
    It should not

@zoul0813 zoul0813 mentioned this pull request Dec 10, 2018
Closed
@coveralls
Copy link

Coverage Status

Coverage remained the same at 89.916% when pulling dfee175 on zoul0813:feature/292-inside-button-type into a484031 on vue-generators:master.

zoul0813 added a commit to vue-generators/vue-form-generator-docs that referenced this pull request Dec 14, 2018
@zoul0813
added docs for "type" attribute, introduced in vue-generators/vue-for…
7d7286c 
…m-generator#558
@zoul0813 zoul0813 mentioned this pull request Dec 14, 2018
Merged
@zoul0813 zoul0813 merged commit 4cc7a7a into vue-generators:master Dec 14, 2018
@zoul0813 zoul0813 deleted the feature/292-inside-button-type branch December 14, 2018 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lionel-bijaoui lionel-bijaoui Awaiting requested review from lionel-bijaoui

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Inside buttons default type
2 participants
@zoul0813 @coveralls