Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes #480 - dates are always passed to "date" and "datetime-local" e… #557

Merged
merged 1 commit into from
Dec 14, 2018

Conversation

zoul0813
Copy link
Member

…lements using the standard format (YYYY-MM-DD or YYYY-MM-DDTHH:mm:ss), and "datetime" elements are converted into "datetime-local" (datetime is deprecated/obsolete).

  • Please check if the PR fulfills these requirements
  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • What is the current behavior? (You can also link to an open issue here)
    When a "format" is not provided, the date/datetime field would be sent a number and throw an exception formatting the value
  • What is the new behavior (if this is a feature change)?
    values are always passed to date/datetime-local field in the correct "YYYY-MM-DDTHH:mm:ss" format as described in the docs
  • Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
    It should not

…etime-local" elements using the standard format (YYYY-MM-DD or YYYY-MM-DDTHH:mm:ss), and "datetime" elements are converted into "datetime-local" (datetime is deprecated/obsolete).
@coveralls
Copy link

Coverage Status

Coverage remained the same at 89.916% when pulling db3413f on zoul0813:feature/480-date-format into a484031 on vue-generators:master.

@zoul0813 zoul0813 merged commit 2550336 into vue-generators:master Dec 14, 2018
@zoul0813 zoul0813 deleted the feature/480-date-format branch December 14, 2018 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Not including 'format' option in schema for an 'inputType: date' fails v2.2.2
2 participants