Add Templates for Exoscale DBaaS products #71
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glrf
force-pushed
the
feat/dbaas-templates
branch
2 times, most recently
from
147714d to
7d4c752
Compare
glrf
force-pushed
the
feat/dbaas-templates
branch
from
7d4c752 to
405babe
Compare
|
@bastjan I requested a review from you so that the APPUiO team is aware of this change in template matching. I don't think it should break anything :) |
zugao
reviewed
Dec 14, 2022
bastjan
approved these changes
Dec 14, 2022
| @@ -41,13 +41,24 @@ func ItemDescriptionTemplateRendererFromFS(fs fs.FS, extension string) (*ItemDes | |||
|
|
|||
| // RenderItemDescription renders an item description. Uses the `.ProductRef.Source` as the key to look which template to use. | |||
There was a problem hiding this comment.
I'd prefer some documentation on the fuzzy matching here.
There was a problem hiding this comment.
Fair point, missed that, thanks. Will add that
Co-authored-by: Sebastian Widmer <sebastian.widmer@vshn.net>
Well there are golden tests. Or what do you mean with test? |
I meant a real test (e2e) or it's not feasible with this repo? |
|
We don't do Odoo e2e tests no. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds Templates for Exoscale DBaaS products.
As there are over 100 DB/Plan combination (and in turn over 100 distinct products in the Billing DB) I extended the template selection to allow for only one template per DB type. This shouldn't impact the current billing behavior as we will do longest prefix match.
Checklist
bug,enhancement,documentation,change,breaking,dependencyas they show up in the changelog