Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Angular guard support #900

Merged
merged 2 commits into from
Apr 30, 2017
Merged

Angular guard support #900

merged 2 commits into from
Apr 30, 2017

Conversation

robertohuertasm
Copy link
Member

@robertohuertasm robertohuertasm commented Apr 30, 2017 •
edited
Loading

Fixes #872

Changes proposed:

  • Add
  • Prepare
  • Delete
  • Fix

Things I've done:

  • My pull request fixes an issue, I referenced the issue.

jens1o
jens1o approved these changes Apr 30, 2017
View reviewed changes
Copy link
Member

@jens1o jens1o left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dat icon. Looks very cool!

@codecov
Copy link

codecov bot commented Apr 30, 2017 •
edited
Loading

Codecov Report

Merging #900 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #900   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          41     41           
  Lines        1886   1886           
  Branches       92     92           
=====================================
  Hits         1886   1886
Impacted Files Coverage Δ
src/icon-manifest/supportedExtensions.ts 100% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3eec97a...d6ca9b9. Read the comment docs.

@robertohuertasm robertohuertasm mentioned this pull request Apr 30, 2017
Closed
@robertohuertasm robertohuertasm merged commit 2930164 into master Apr 30, 2017
@robertohuertasm robertohuertasm deleted the feature-ng-guard branch April 30, 2017 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jens1o jens1o jens1o approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Icon Request] Support for .guard.ts in Angular 2+
2 participants
@robertohuertasm @jens1o