Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add more folder names for Kubernetes #2135

Merged
merged 4 commits into from
Jul 20, 2019
Merged

Add more folder names for Kubernetes #2135

merged 4 commits into from
Jul 20, 2019

Conversation

mmisztal1980
Copy link
Contributor

@mmisztal1980 mmisztal1980 commented Jul 15, 2019 •
edited by JimiC
Loading

**Fixes #2134 **

Changes proposed:

  • Add
  • Delete
  • Fix
  • Prepare

Sometimes developers wish to have their k8s folders at the top of their folder structure for improved visibility. When prefixing the folders with a dot, the vscode-icons' icon is lost.

This PR adds the kubernetes folder icon to following folders:

  • .k8s
  • .kube

@codecov
Copy link

codecov bot commented Jul 15, 2019 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (master@6f57fbb). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##             master   #2135   +/-   ##
========================================
  Coverage          ?    100%           
========================================
  Files             ?      78           
  Lines             ?    5959           
  Branches          ?     138           
========================================
  Hits              ?    5959           
  Misses            ?       0           
  Partials          ?       0
Impacted Files Coverage Δ
src/iconsManifest/supportedFolders.ts 100% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6f57fbb...dea111e. Read the comment docs.

@codecov
Copy link

codecov bot commented Jul 15, 2019

Codecov Report

Merging #2135 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #2135   +/-   ##
======================================
  Coverage     100%    100%           
======================================
  Files          78      78           
  Lines        5959    5959           
  Branches      138     138           
======================================
  Hits         5959    5959
Impacted Files Coverage Δ
src/iconsManifest/supportedFolders.ts 100% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ce692b5...0ac8d91. Read the comment docs.

@JimiC JimiC changed the title Fixes #2134 Add more folder names for Kubernetes Jul 15, 2019
JimiC
JimiC requested changes Jul 15, 2019
View reviewed changes
Copy link
Member

@JimiC JimiC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since you are doing this can you please add also the dot variant for the other naming?

@mmisztal1980
Copy link
Contributor Author

Since you are doing this can you please add also the dot variant for the other naming?

@JimiC remaining folders prefixed, as requested

@mmisztal1980 mmisztal1980 reopened this Jul 15, 2019
@mmisztal1980
Copy link
Contributor Author

@JimiC is there anything else required in order for this to be merged?

@JimiC
Copy link
Member

JimiC commented Jul 16, 2019

Only your patience

@robertohuertasm robertohuertasm added this to the v9 milestone Jul 20, 2019
@robertohuertasm robertohuertasm merged commit 0b739f6 into vscode-icons:master Jul 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JimiC JimiC JimiC approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
9.0.0
Development

Successfully merging this pull request may close these issues.

[Icon Request] Support ".k8s" folders to use the existing "k8s" folder icon
3 participants
@mmisztal1980 @JimiC @robertohuertasm