Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add better support for Django #1622

Merged
merged 2 commits into from
Jun 16, 2018

Conversation

blfpd
Copy link
Contributor

@blfpd blfpd commented Jun 10, 2018

Changes proposed:

  • Add
  • Delete
  • Fix
  • Prepare

Add the file type django for django-html.

The file type is introduce by the/my extension vscode-django which avoid shadowing the html file type.

@codecov
Copy link

codecov bot commented Jun 10, 2018

Codecov Report

Merging #1622 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #1622   +/-   ##
======================================
  Coverage     100%    100%           
======================================
  Files          50      50           
  Lines        2848    2848           
  Branches      138     138           
======================================
  Hits         2848    2848
Impacted Files Coverage Δ
src/icon-manifest/supportedExtensions.ts 100% <ø> (ø) ⬆️
src/icon-manifest/languages.ts 100% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8ca4bc1...aa3b6cc. Read the comment docs.

@JimiC
Copy link
Member

JimiC commented Jun 11, 2018

Why don't you add django-txt as well, while you are at it?

@blfpd
Copy link
Contributor Author

blfpd commented Jun 11, 2018

@JimiC I actually wanted to, and then reverted my changes fearing that would slow the merging process.
I’ll happily add it!

@blfpd blfpd force-pushed the feature/extra-django branch from 2091163 to 1acf08b Compare June 11, 2018 13:11
@JimiC
Copy link
Member

JimiC commented Jun 11, 2018

You do not need to declare new ILanguage. A simple array of ids on the existing declaration will suffice.

@JimiC
Copy link
Member

JimiC commented Jun 11, 2018

Make

django: { ids: 'django-html', defaultExtension: 'html' },

to

django: { ids: ['django-html', 'django-txt'], defaultExtension: 'html' },

and you are done. Don't worry about defaultExtension. It's a helper attribute for our examples generator tool. Doesn't play any role in the extension.

@blfpd
Copy link
Contributor Author

blfpd commented Jun 11, 2018

Oh I see, cool thanks!

@blfpd blfpd force-pushed the feature/extra-django branch from 1acf08b to 62ca9e5 Compare June 11, 2018 13:25
@blfpd
Copy link
Contributor Author

blfpd commented Jun 11, 2018

@JimiC Is it good like that?

(Is the last check hung?)

@JimiC JimiC added this to the Next milestone Jun 12, 2018
@codeclimate
Copy link

codeclimate bot commented Jun 16, 2018

Code Climate has analyzed commit aa3b6cc and detected 0 issues on this pull request.

View more on Code Climate.

@robertohuertasm robertohuertasm merged commit a60581b into vscode-icons:master Jun 16, 2018
@blfpd
Copy link
Contributor Author

blfpd commented Jun 19, 2018

@robertohuertasm I hope I’m not pushy if I ask what’s blocking for a new release. 🙂

@robertohuertasm
Copy link
Member

Don't worry! We were just discussing that. That's been my fault for this release (too much things going on outside of Github) but hopefully this will be solved with the new changes introduced by @JimiC allowing new releases from any team member.

The new version will be released today or tomorrow!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants