Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use except Exception instead of bare except #237

Merged
merged 1 commit into from
Dec 23, 2022
Merged

use except Exception instead of bare except #237

merged 1 commit into from
Dec 23, 2022

Conversation

kaczmarj
Copy link
Contributor

A bare except will catch KeyboardInterrupt and SystemExit, making it hard to stop the program with control+C. Using except Exception will catch all other exceptions.

@kaczmarj
use except Exception instead of bare except
cc35778 
A bare `except` will catch `KeyboardInterrupt` and `SystemExit`, making it hard to stop the program with control+C. Using `except Exception` will catch all other exceptions.
@vqdang vqdang merged commit 326f17e into vqdang:master Dec 23, 2022
@kaczmarj kaczmarj deleted the patch-1 branch August 22, 2023 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vqdang vqdang vqdang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kaczmarj @vqdang