Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sequence is not respected #1267

Open
toughlex-donatas opened this issue Dec 22, 2024 · 3 comments
Open

sequence is not respected #1267

toughlex-donatas opened this issue Dec 22, 2024 · 3 comments
Assignees

Comments

@toughlex-donatas
Copy link

toughlex-donatas commented Dec 22, 2024

https://www.w3schools.com/xml/el_sequence.asp

The sequence element specifies that the child elements must appear in a sequence.

https://learn.microsoft.com/en-us/previous-versions/dotnet/netframework-4.0/ms256089(v=vs.100)

Requires the elements in the group to appear in the specified sequence within the containing element.

This library does not ensure this behavior.

Probably needed changes are somewhere here

let currentChildXmlnsAttrib = '';

@w666 w666 self-assigned this Dec 25, 2024
@w666
Copy link
Collaborator

w666 commented Dec 25, 2024

Hi @toughlex-donatas,

Could you please add a bit more details? How did you find this issue? Is there an example that you can share, like code snippet or xml file?

Thanks.

@toughlex-donatas
Copy link
Author

To replicate the problem you could create a test in https://github.com/vpulim/node-soap/blob/master/test/wsdl-test.js and use this wsdl https://github.com/vpulim/node-soap/blob/master/test/wsdl/marketo.wsdl
Try to call GetLeadChanges for example, you will see that SOAP XML ParamsGetLeadChanges will not have its children ordered in correct order.
There are APIs that don't work with unordered sequence elements.

@w666
Copy link
Collaborator

w666 commented Jan 6, 2025

Had a look on it, does not look like an easy fix. Will have another look later when have more time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants