Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added rspec tests for types and splunk_config and other bugfixes #55

Merged
merged 6 commits into from
Oct 3, 2016
Merged

Added rspec tests for types and splunk_config and other bugfixes #55

merged 6 commits into from
Oct 3, 2016

Conversation

crayfishx
Copy link
Contributor

  • Added rspec tests for splunk types
  • Added rspec tests for splunk_config
  • Bugfix: splunk_input file_path not being set
  • Bugfix: calling provider file_path method from a variable

@crayfishx
Added rspec tests for types and splunk_config and other bugfixes
97c5d67 
* Added rspec tests for splunk types
* Added rspec tests for splunk_config
* Bugfix: splunk_input file_path not being set
* Bugfix: calling provider file_path method from a variable
@crayfishx
renamed klass to provider_class and type_class
548513c
@crayfishx
rubocop fixes
2179afd
@alexjfisher
Copy link
Member

@crayfishx Did bead52a break the module?

@crayfishx
Copy link
Contributor Author

@alexjfisher Im not entirely sure - but calling Puppet::Type.type(:foo).provider(:ini_file).file_path = didn't work when I was writing the rspec tests, but does work when it is assigned to a variable - which is a bit odd - either way it reads better and is more understandable as a variable assignment to make it clear that we're calling a class method in the provider.

@apenney
Copy link

apenney commented Oct 3, 2016

@crayfishx I'd prefer a nice Fira Mono, possibly italicized..

@rnelson0 rnelson0 merged commit 6e8ad21 into voxpupuli:master Oct 3, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@crayfishx @alexjfisher @apenney @rnelson0