Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix module errors discovered while testing. #42

Merged
merged 1 commit into from
Apr 4, 2016

Conversation

Ziaunys
Copy link
Contributor

@Ziaunys Ziaunys commented Apr 1, 2016

  • Depends on Add acceptance test skeleton. #41
  • The $splunk_user variable was referenced but undeclared.
    for this repo.
  • Update the build and version to correctly reference the most recent
    values.
  • The $staged_package variable was referenced before declaration.
  • Creates separate spec files for testing the splunk and
    splunk::forwarder classes.
  • Removes the path parameter from the enable_splunk and
    enable_splunkforwarder execs because it causes issues on platforms
    that use the systemd service provider. The resulting init script that
    the exec generates will not get loaded by the systemd-sysv-generate
    module.
  • Fixes an issue where the splunkweb Service would change from 'stopped'
    to 'running' on every Puppet run. The pattern for discovering the
    running service had an incorrect regex.

- The $splunk_user variable was referenced but undeclared.
  for this repo.
- Update the build and version to correctly reference the most recent
  values.
- The $staged_package variable was referenced before declaration.
- Creates separate spec files for testing the splunk and
  splunk::forwarder classes.
- Removes the path parameter from the enable_splunk and
  enable_splunkforwarder execs because it causes issues on platforms
  that use the systemd service provider. The resulting init script that
  the exec generates will not get loaded by the systemd-sysv-generate
  module.
- Fixes an issue where the splunkweb Service would change from 'stopped'
  to 'running' on every Puppet run. The pattern for discovering the
  running service had an incorrect regex.
@kfjohnson
Copy link
Contributor

+1

@bmjen
Copy link
Member

bmjen commented Apr 4, 2016

Great work @Ziaunys !

@bmjen bmjen merged commit 0875a4e into voxpupuli:master Apr 4, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants