New Custom Type For Managing .meta files #176
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @michaelweiser, thanks for the PR! Can you take a look at the failing spec tests? |
|
I think those are related to the staged_package problem you addressed in #179. They were happening with unmodified puppet-splunk when running the testsuite locally as well. I do not think they're related to my changes. |
|
@michaelweiser yes correct, I just noticed this too. We're currently working on a fix in #179. Please feel free to take a look. |
This change enables the module to manage default.meta and local.meta
files in splunk system and app contexts. This allows to deploy access
control and export settings.
The patch introduces a new type splunk_metadata which behaves similar to
the other types and has the same interface. Internally however it
redirects to the metadata directory of the system or app contexts and
manages the files default.meta or local.meta respectively.
Example:
splunk_metadata { 'app foo system export':
section => '',
setting => 'export',
value => 'system',
context => 'app/foo/default',
# -> $SPLUNK_HOME/etc/app/foo/metadata/default.meta
}
splunk_metadata { 'system access':
section => '',
setting => 'access',
value => 'read : [ me ], write : [ admin ]',
# context default system local
# -> $SPLUNK_HOME/etc/system/metadata/local.meta
}
Metadata files regularly have a section with an empty name ([])
containing the app access permissions. Since Puppet's IniFile class does
not support this directly, the provider subclasses
Puppet::Util::IniFile::Section and Puppet::Util::IniFile to add the
necessary functionality.
Additionally, the context parameter is made a namevar so that multiple
sections and settings with the same name can exist in different
contexts.
|
With #179 fixed the tests now succeed. |
TraGicCode
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change enables the module to manage default.meta and local.meta
files in splunk system and app contexts. This allows to deploy access
control and export settings.
The patch introduces a new type splunk_metadata which behaves similar to
the other types and has the same interface. Internally however it
redirects to the metadata directory of the system or app contexts and
manages the files default.meta or local.meta respectively.
Example:
Metadata files regularly have a section with an empty name ([])
containing the app access permissions. Since Puppet's IniFile class does
not support this directly, the provider subclasses
Puppet::Util::IniFile::Section and Puppet::Util::IniFile to add the
necessary functionality.
Additionally, the context parameter is made a namevar so that multiple
sections and settings with the same name can exist in different
contexts.