Fix changelog #73
Merged
Fix changelog #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For github-changelog-generator to automatically detect the `--since-tag` release headers need to be consistent with the format the tool uses. ie. ``` ## $TAG ($DATE) ``` I've removed 1.3.0 and 1.4.0 as I think the autogenerated entries for these versions is probably better than what was manually written.
alexjfisher
commented
Sep 1, 2017
| @@ -1,6 +1,6 @@ | |||
| { | |||
| "name": "puppet-logrotate", | |||
| "version": "2.0.1-rc0", | |||
| "version": "3.0.0-rc0", | |||
There was a problem hiding this comment.
Next version will be a new major release because of the breaking change.
alexjfisher
commented
Sep 1, 2017
| @@ -37,7 +37,8 @@ begin | |||
| version = (Blacksmith::Modulefile.new).version | |||
| config.future_release = "v#{version}" | |||
| config.header = "# Change log\n\nAll notable changes to this project will be documented in this file.\nEach new release typically also includes the latest modulesync defaults.\nThese should not impact the functionality of the module." | |||
| config.exclude_labels = %w{duplicate question invalid wontfix modulesync} | |||
| config.exclude_labels = %w{duplicate question invalid wontfix wont-fix modulesync} | |||
There was a problem hiding this comment.
This module needs a full modulesync really, but this was enough for me.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #69