Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Manage option to use a custom lookup function #80

Merged
merged 4 commits into from
Mar 14, 2024
Merged

Manage option to use a custom lookup function #80

merged 4 commits into from
Mar 14, 2024

Conversation

tuxmea
Copy link
Member

@tuxmea tuxmea commented Mar 14, 2024

Some people have written their own custom lookup function. HDM needs to know if the function returns yaml or eyaml.

@tuxmea
Manage option to use a custom lookup function
dae7f06 
Some people have written their own custom lookup function.
HDM needs to know if the function returns yaml or eyaml.
@tuxmea tuxmea requested review from bastelfreak and rwaffen March 14, 2024 09:21
@bastelfreak bastelfreak added the enhancement New feature or request label Mar 14, 2024
bastelfreak
bastelfreak reviewed Mar 14, 2024
View reviewed changes
manifests/init.pp Outdated Show resolved Hide resolved
rwaffen
rwaffen reviewed Mar 14, 2024
View reviewed changes
Copy link
Member

@rwaffen rwaffen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why so complicated with the hash? are there coming more options to set? otherwise wouldn't it be simpler to make it just a enum?

templates/hdm.yml.epp Outdated Show resolved Hide resolved
@tuxmea
Copy link
Member Author

tuxmea commented Mar 14, 2024

why so complicated with the hash? are there coming more options to set? otherwise wouldn't it be simpler to make it just a enum?

We need to know the function name and map this to yaml or eyaml.
I decided to go for a single Hash with the function name as key and the mapping as value.

@tuxmea tuxmea requested review from bastelfreak and rwaffen March 14, 2024 09:42
@tuxmea tuxmea mentioned this pull request Mar 14, 2024
Closed
@tuxmea tuxmea merged commit 5a0a720 into voxpupuli:master Mar 14, 2024
3 checks passed
@tuxmea tuxmea deleted the custom_function branch March 14, 2024 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rwaffen rwaffen rwaffen approved these changes

@bastelfreak bastelfreak Awaiting requested review from bastelfreak

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tuxmea @bastelfreak @rwaffen