Updated date-time regex to accept zero or one of : in the timezone designator #85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
October 31, 2013 13:02
|
Typically you should avoid editing version files since when the release is made is up to the project's committers. I'd say make a new PR without that change to the version file. |
This reverts commit b0bcb8d.
|
Reverted the commit. |
|
hopefully @hoxworth has some time soon to run through a few of the pending PR's |
|
I've just noticed I've made a massive error on the tests. assert(!JSON::Validator.validate(schema,data))The tests are returning false and then getting flipped to true. I'll try and fix this problem and update the PR. Regards, |
|
Added two new commits which now rectify the issues I had in my previous comment, it turns out the tests had an invalid iso-8601 date-time (never try and rush a PR on your lunch break). Cheers, |
hoxworth
added a commit
that referenced
this pull request
Dec 31, 2013
Updated date-time regex to accept zero or one of : in the timezone designator
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Kenny,
I've updated the date-time regex to accept zero or one of ":" in the timezone. I've noticed that the ISO-8601 standard states (http://www.w3.org/TR/NOTE-datetime) that there should always be a colon but have found that in other sources that sometimes the colon doesn't appear. Please see the sources below:
I've added a few tests within test_jsonschema_draft4.rb and removed a test which no longer fails in test_jsonschema_draft3.rb.
Let me know if you want anything else added? If you don't want to merge this PR for any reason no worries, if you could let me know why (just out of interest) that would be great.
Regards,
Jon