Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix more rubocop violations #488

Merged
merged 15 commits into from
Feb 17, 2023
Merged

Fix more rubocop violations #488

merged 15 commits into from
Feb 17, 2023

Conversation

bastelfreak
Copy link
Member

No description provided.

@codecov
Copy link

codecov bot commented Feb 17, 2023

Codecov Report

Base: 89.99% // Head: 89.98% // Decreases project coverage by -0.01% ⚠️

Coverage data is based on head (e176cd9) compared to base (92cb1f6).
Patch coverage: 100.00% of modified lines in pull request are covered.

❗ Current head e176cd9 differs from pull request most recent head 91687a5. Consider uploading reports for the commit 91687a5 to get more accurate results

Additional details and impacted files 
@@            Coverage Diff             @@
##           master     #488      +/-   ##
==========================================
- Coverage   89.99%   89.98%   -0.01%     
==========================================
  Files          76       76              
  Lines        1579     1578       -1     
==========================================
- Hits         1421     1420       -1     
  Misses        158      158
Impacted Files Coverage Δ
lib/json-schema/attribute.rb 100.00% <100.00%> (ø)
lib/json-schema/attributes/enum.rb 93.33% <100.00%> (ø)
lib/json-schema/errors/validation_error.rb 100.00% <100.00%> (ø)
lib/json-schema/schema.rb 96.96% <100.00%> (ø)
lib/json-schema/schema/validator.rb 87.50% <100.00%> (ø)
lib/json-schema/util/uuid.rb 47.40% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@bastelfreak bastelfreak merged commit e697968 into voxpupuli:master Feb 17, 2023
@bastelfreak bastelfreak deleted the rubocop branch February 17, 2023 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arjenz arjenz arjenz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bastelfreak @arjenz