update README.md/gemspec; migrate to GitHub actions #456
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bastelfreak
force-pushed
the
migrate
branch
2 times, most recently
from
72f63ac to
bc828f0
Compare
Codecov Report
@@ Coverage Diff @@
## master #456 +/- ##
=========================================
Coverage ? 89.75%
=========================================
Files ? 74
Lines ? 1581
Branches ? 0
=========================================
Hits ? 1419
Misses ? 162
Partials ? 0 Continue to review full report at Codecov.
|
TuningYourCode
approved these changes
Sep 2, 2021
ekohl
reviewed
Sep 2, 2021
Comment on lines
+18
to
+19
| env: | ||
| BUNDLE_WITHOUT: release |
There was a problem hiding this comment.
This is useless. There is no bundler involved so it can be dropped.
| echo ":github: Bearer ${{ secrets.GITHUB_TOKEN }}" >> ~/.gem/credentials | ||
| chmod 0600 ~/.gem/credentials | ||
| - name: Publish gem to GitHub packages | ||
| run: gem push --key github --host https://rubygems.pkg.github.com/voxpupuli *.gem |
There was a problem hiding this comment.
Please don't hardcode voxpupuli. See https://github.com/voxpupuli/.github/blob/master/workflow-templates/gem-release.yml for an example.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.