Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add const validator to draft6. #425

Merged
merged 3 commits into from
Feb 3, 2023
Merged

Conversation

torce
Copy link
Contributor

@torce torce commented Nov 9, 2018

Ignored all draft7 tests in common suite.

Ignored all draft7 tests in common suite.
@pboling
Copy link

pboling commented Feb 14, 2021

#423 (comment)

@codecov
Copy link

codecov bot commented Feb 3, 2023

Codecov Report

Base: 89.99% // Head: 89.99% // No change to project coverage 👍

Coverage data is based on head (9c69a82) compared to base (5ae8c63).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #425   +/-   ##
=======================================
  Coverage   89.99%   89.99%           
=======================================
  Files          76       76           
  Lines        1579     1579           
=======================================
  Hits         1421     1421           
  Misses        158      158           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@torce
Copy link
Contributor Author

torce commented Feb 3, 2023

@bastelfreak Since this feature was already merged in #471, I have reduced this PR to just enable the "const" tests of the common test suite which was the only missing part of #471.

@bastelfreak bastelfreak changed the title Added const validator to draft6. Add const validator to draft6. Feb 3, 2023
@bastelfreak
Copy link
Member

@torce thanks for the work!

@bastelfreak bastelfreak merged commit 27cfae5 into voxpupuli:master Feb 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants