Changed draft-06 url back from /draft/schema# to /draft-06/schema# #388
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We are interested in seeing this merged! |
|
I'm also very interested in seeing this merged. |
|
Yes, I am also very interested! |
|
@iainbeeston the official draft-06 meta-schema URI is http://json-schema.org/draft-06/schema# I'm not sure why it wasn't available at the time, I did not do the deployment of that draft, but it has been there for some time now. If you use http://json-schema.org/draft/schema# that's now draft-07 (I'd love to get rid of the unnumbered URI but too many people depend on it apparently). |
Originally, when I added draft6 support there were draft06 tests in the common test suite, but no meta schema was available, so I assumed the url would match the format of older drafts (ie. http://json-schema.org/draft-06/schema#) Then when the first version of the draft6 meta schema was released, it's official url was http://json-schema.org/draft/schema# (although it wasn't available on json-schema.org, it was only available on github.com). Now the draft6 metaschema is being hosted on json-schema.org, and the url matches what I'd originally predicted: http://json-schema.org/draft-06/schema#, so I've changed it back again. Because of that, this is largely a revert for 87e7b0a, but I've also updated the meta schema to the latest version and updated the `update_meta_schemas` rake task to remove the redirect to github.com to download the meta schema.
chelnak
force-pushed
the
update-draft06-meta-schema
branch
from
b28770e to
7b59bbd
Compare
bastelfreak
reviewed
Apr 24, 2023
chelnak
force-pushed
the
update-draft06-meta-schema
branch
from
8629afe to
cd3ac64
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Originally, when I added draft6 support there were draft06 tests in
the common test suite, but no meta schema was available, so I assumed
the url would match the format of older
drafts (ie. http://json-schema.org/draft-06/schema#)
Then when the first version of the draft6 meta schema was released,
it's official url was http://json-schema.org/draft/schema# (although
it wasn't available on json-schema.org, it was only available on
github.com).
Now the draft6 metaschema is being hosted on json-schema.org, and the
url matches what I'd originally predicted:
http://json-schema.org/draft-06/schema#, so I've changed it back
again.
Because of that, this is largely a revert for
87e7b0a, but I've also updated the
meta schema to the latest version and updated the
update_meta_schemasrake task to remove the redirect to github.comto download the meta schema.