Made sure we require timeout before using it #385
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iainbeeston
force-pushed
the
absolute-class-for-timeout
branch
from
6c980a6 to
4d7237c
Compare
iainbeeston
force-pushed
the
absolute-class-for-timeout
branch
from
4d7237c to
9f72fa9
Compare
|
@RST-J Could I please get a review of this too? |
If you run `JSON::Validator.validate(metaschema, "http://a/%%30%30")` then you'll see the error "uninitialized constant Timeout". This is happening because we reference `Timeout` in `Validator` without requiring it. Interestingly I can't reproduce this error in the test suite because something else (probably webmock?) is already requiring timeout for us, and this error does not occur. Fixes voxpupuli#384
iainbeeston
force-pushed
the
absolute-class-for-timeout
branch
from
9f72fa9 to
0fbbb4e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you run
JSON::Validator.validate(metaschema, "http://a/%%30%30")then you'll see the error "uninitialized constant Timeout". This is
happening because we reference
TimeoutinValidatorwithoutrequiring it.
Interestingly I can't reproduce this error in the test suite because
something else (probably webmock?) is already requiring timeout for
us, and this error does not occur.
Fixes #384