Corrected the draf6 schema id #376
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Draft6 is a work in progress. The maintainers for now are using the schema id "http://json-schema.org/draft/schema#". Previously I had assumed it would follow the naming convention of the previous drafts (and include the version number in the name). Unfortunately I was wrong, so now I've updated it to use the correct schema id. I've also updated the meta schema to the latest version.
iainbeeston
force-pushed
the
update-draft6-schema-id
branch
from
d7f23cb to
87e7b0a
Compare
smortex
added a commit
to smortex/pdk
that referenced
this pull request
Oct 15, 2019
Version 2.8.0 of the json-schema gem assumed the WIP draft 6 URI would be "http://json-schema.org/draft-06/schema#". It happens that it is in fact "http://json-schema.org/draft/schema#". This was fixed in: voxpupuli/json-schema#376 json-schema PATCH vesion was bumped, so that version 2.8.1 include this fix.
smortex
added a commit
to smortex/pdk
that referenced
this pull request
Oct 15, 2019
Version 2.8.0 of the json-schema gem assumed the WIP draft 6 URI would be "http://json-schema.org/draft-06/schema#". It happens that it is in fact "http://json-schema.org/draft/schema#". This was fixed in: voxpupuli/json-schema#376 json-schema PATCH vesion was bumped, so that version 2.8.1 include this fix. Instead of depending on a buggy version of this gem and using the same wrong URI, switch to the fixed version of the gem and use the expected URI.
smortex
added a commit
to smortex/pdk
that referenced
this pull request
Oct 23, 2019
Version 2.8.0 of the json-schema gem assumed the WIP draft 6 URI would be "http://json-schema.org/draft-06/schema#". It happens that it is in fact "http://json-schema.org/draft/schema#". This was fixed in: voxpupuli/json-schema#376 json-schema PATCH vesion was bumped, so that version 2.8.1 include this fix. Instead of depending on a buggy version of this gem and using the same wrong URI, switch to the fixed version of the gem and use the expected URI.
smortex
added a commit
to smortex/pdk
that referenced
this pull request
Oct 25, 2019
Version 2.8.0 of the json-schema gem assumed the WIP draft 6 URI would be "http://json-schema.org/draft-06/schema#". It happens that it is in fact "http://json-schema.org/draft/schema#". While this issue was fixe in voxpupuli/json-schema#376 and json-schema 2.8.1 was released with this fix, it does not fix our problem. But since we do not depend on draft-06 features, downgrade to draft-04 (there is no draft-05).
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Draft6 is a work in progress. The maintainers for now are using the
schema id "http://json-schema.org/draft/schema#". Previously I had
assumed it would follow the naming convention of the previous
drafts (and include the version number in the name). Unfortunately I
was wrong, so now I've updated it to use the correct schema id.
I've also updated the meta schema to the latest version.