Use latest json-schema draft in tests by default #359
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I agree. |
Lots of core tests were explicitly using draft-03, which works slightly differently to the latest (eg. draft-04). I've updated all tests to not specify the schema version at all (so they default to using the latest).To me this feels safer, as (unless explicitly specified) we will always testing against the default json-schema draft. The main change has been the way that the "required" property is defined (moving from the definition of each "property" to being defined as an array alongside the "properties" object).
iainbeeston
force-pushed
the
use-latest-draft-in-tests
branch
from
91e892f to
aebac88
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lots of core tests were explicitly using draft-03, which works slightly
differently to the latest (draft-04 as I write this). I've rewritten
them to not specify the schema version at all, so they default to using
the latest.
To me this feels safer, as (unless explicitly specified) we're always
testing against the default draft.
The main change here is the way that the "required" property has
changed (moving from being defined on the definition of each "property"
to being defined alongside the "properties" object).