Simplified #validator_for methods
#346
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iainbeeston
force-pushed
the
simplify-validator-for-methods
branch
from
0d73a7a to
56f4569
Compare
iainbeeston
force-pushed
the
simplify-validator-for-methods
branch
from
56f4569 to
3a25e8b
Compare
Right now there is: * `#validator_for` * `#validator_for_uri` * `#validator_for_name` * `#validators_for_names` But in reality all delegate to either `#validator_for_uri` or `#validator_for_name`. This is confusing, and obfuscates what's really going on. I've removed `#validators_for_names` (which was a private method anyway) and deprecated the alias of `#validator_for`.
iainbeeston
force-pushed
the
simplify-validator-for-methods
branch
from
3a25e8b to
fd45475
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now there is:
#validator_for#validator_for_uri#validator_for_name#validators_for_namesBut in reality all delegate to either
#validator_for_urior#validator_for_name. This is confusing, and obfuscates what's reallygoing on.
I've removed
#validators_for_names(which was a private method anyway)and deprecated the alias of
#validator_for.