Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow boolean false as a default property. #238

Merged
merged 2 commits into from
Mar 14, 2015
Merged

Allow boolean false as a default property. #238

merged 2 commits into from
Mar 14, 2015

Conversation

chrisandreae
Copy link
Contributor

No description provided.

@iainbeeston
Copy link
Contributor

Good catch. Could you please add a test to show that false works as a default now? (I assume you're using Json Schema to insert defaults?)

@RST-J
Copy link
Contributor

RST-J commented Mar 11, 2015

👍

2 similar comments
@hoxworth
Copy link
Contributor

👍

@iainbeeston
Copy link
Contributor

👍

iainbeeston added a commit that referenced this pull request Mar 14, 2015
@iainbeeston
Merge pull request #238 from cerego/master
8b607ea 
Allow boolean false as a default property.
@iainbeeston iainbeeston merged commit 8b607ea into voxpupuli:master Mar 14, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@chrisandreae @iainbeeston @RST-J @hoxworth