Enabled warnings when running tests #231
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Actually, we need sporkmonger/addressable#180 to be merged before this is feasible (addressable throws up a lot of warnings) |
iainbeeston
force-pushed
the
test-warnings
branch
from
edb6398 to
963c3ef
Compare
iainbeeston
force-pushed
the
test-warnings
branch
from
963c3ef to
6905dcb
Compare
Older versions raised ruby warnings
|
This is now good to merge, as addressable has been fixed. Could someone in the core team please check it over? (TL;DR the test suite now shows ruby warnings if there are any) |
|
👍 |
|
Thanks @RST-J - I think this is a fairly minor change so I'll merge it now |
iainbeeston
added a commit
that referenced
this pull request
Apr 3, 2015
Enabled warnings when running tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned in #219 we want to avoid issues such as redefined methods. Running tests with warnings enabled should help.
Note that this shows up warnings for some existing issues, including some in addressable, so I recommend we merge #226 before this