Renamed variable in oneOf to avoid name clash #221
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clashes with a method with the same name
|
👍 |
|
Looks good -- although Ruby is smart enough to distinguish between local variables and instance methods. |
|
My intention is to make the code easier to understand, and to get rid of
warning messages in Ruby and linters like rubocop. Functionally it makes no
difference
|
|
👍 |
RST-J
added a commit
that referenced
this pull request
Feb 23, 2015
Renamed variable in oneOf to avoid name clash
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed in #216 that we have some bad variable naming. In the OneOf attribute, there's a
validation_errorsinstance variable, but the parent (Attribute) class defines avalidation_errors()method. So in the same file we have both a method and a variable with the same name. This seems to work, but it's confusing and seems like a bad idea.This renames that variable to
validation_error_count, to avoid confusion