-
-
Notifications
You must be signed in to change notification settings - Fork 242
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show sub-errors for oneOf #216
Conversation
Great idea, could you add some tests for this similar to those for any of and all of? |
Also, this change seems to cause a test failure related to oneOf |
Looking at the test, i'm not sure why it was working before. But still, there's seems to be an error in my patch, because even {foo => view} doesn't seem to validate |
Oh, okay, i finally get, how test works. "default" inserts value only for one oneOf case, which will fail with strict, and the first one will pass. |
Okay, i've added tests for sub-errors |
Seems fine to me 👍 |
Ok, I'm happy with this 👍 Merging |
anyOf and allOf show sub-errors.
with this patch oneOf do the same