-
-
Notifications
You must be signed in to change notification settings - Fork 242
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added bundler gem management rake tasks #211
Conversation
What do the GemHelper tasks do? Will they perform the test task and increase the version number and then release? If so, cool. |
It does everything except run tests. We could easily add tests as a dependency, but not for multiple versions of Ruby. Personally I think even that is unnecessary. I think we have to trust that releases aren't rushed and people check Travis first.= |
I thought of this because Travis is not rerun when things get merged, as the incident yesterday showed. |
I thought Travis usually does run a build after a merge, because it's just another commit? I know they had a large backlog yesterday (there was a disclaimer saying their linux builds were backed up) so it might have been a one-off?= |
I don't know. I meant other PRs that are open and have been built before. If they are green and then another PR is merged, other pending PRs are not retested or are they? |
Ah no - my understanding is that a build is triggered whenever there is a new commit. For unrelated branches, there's no change, so travis doesn't build. There is some discussion of adding this feature: travis-ci/travis-ci#1620 |
The process I've always followed was:
Seems as if the only thing that bundler adds is consolidating step 3 & 4 above, correct (and probably not using an annotated tag in the process)? Reducing steps is definitely a good thing... but it wold be great if there were a single release target that would update Anyway, just a comment. I'm okay with merging this to reduce at least one step. |
I think the bundler tasks do 3, 4, 5 and 6 (can't remember if it pushes the tags back up, but I have a feeling that it does) |
(That's the release task I'm thinking of) |
@iainbeeston's right, bundler's
👍 |
Added bundler gem management rake tasks
Ok, two observations:
|
Ah... It pushes tags to origin - which is my personal fork of the repo... |
Bundler has a selection of rake tasks that can make releasing a gem a lot easier. I've added those to the Rakefile.
I've also tidied up the Rakefile a little in the process and added bundler as a dev dependency (which was always assumed, but not explicitly stated, before)