-
-
Notifications
You must be signed in to change notification settings - Fork 242
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WebMock is on globally now; no need to disable it #208
Conversation
Introduced by conflicts in how voxpupuli#175 and voxpupuli#196 juggled webmock usage. Closes voxpupuli#207.
Ah I see - that's because of me. 👍 |
Eek, still some errors for the other JSON backends. Will figure it out soon. |
Each json backend has it’s own parsing error classes - they all inherit from standard error though (I had the same problem when writing tests to check initialize_data, across different backends)= |
Incidentally, I put in place a “refute_block” helper method in the initialize_data test - that might help you (and I meant to move it into test_helper.rb, so it could be reused, but never did)= |
I'm not thrilled with how I just dealt with it in f263094, but I really did want the test to be fairly explicit about "the JSON parse error should be allowed to bubble up", not just "something could raise here". Checking for the currently defined modules is the best I could come up with ... =\ |
If someone has a better idea some time we can change that then. |
Actually, that’s not bad - can you put that in test_helper? Perhaps rename it as “assert_raises_parse_error”? I’d like to reuse it in a test I wrote for initialize_data= |
Tell you what, I'll refactor both. Merging |
WebMock is on globally now; no need to disable it
Introduced by conflicts in how #175 and #196 juggled webmock usage.
Closes #207.