Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unused Schema#base_uri method #193

Merged
merged 1 commit into from
Nov 28, 2014
Merged

Remove unused Schema#base_uri method #193

merged 1 commit into from
Nov 28, 2014

Conversation

pd
Copy link
Contributor

@pd pd commented Nov 28, 2014

This removes an unused method from JSON::Schema; there's no test coverage on it, and it's not very clear what it's meant to be used for. The only commit that has ever referenced it is the very first commit to this repo:

$ git log -S base_uri
commit d1c7b421bbb04d00b06c49e6ebb5ba773d756b12
Author: Kenny Hoxworth <hoxworth@gmail.com>
Date:   Wed Nov 24 15:11:09 2010 -0500

    Initial commit.

@iainbeeston
Copy link
Contributor

Good catch

👍

RST-J added a commit that referenced this pull request Nov 28, 2014
@RST-J
Merge pull request #193 from pd/rm-unused-method
41ebebe 
Remove unused Schema#base_uri method
@RST-J RST-J merged commit 41ebebe into voxpupuli:master Nov 28, 2014
@RST-J
Copy link
Contributor

RST-J commented Nov 28, 2014

👍 (imagine this comment to appear before the merge)

@pd pd deleted the rm-unused-method branch December 2, 2014 22:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pd @iainbeeston @RST-J