Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend common-test-suite to ignore individual test cases #171

Merged
merged 2 commits into from
Oct 30, 2014

Conversation

mpalmer
Copy link
Contributor

@mpalmer mpalmer commented Oct 29, 2014

As per later comments on #163. I've added an example for how to exclude specific tests, although it's a pointless example because it's excluding all the tests in the file.

@RST-J
Copy link
Contributor

RST-J commented Oct 29, 2014

👍

@pd
Copy link
Contributor

pd commented Oct 29, 2014

👍

@pd
Copy link
Contributor

pd commented Oct 30, 2014

Eek, actually, I think this adds back some mid-test-run noise that @iainbeeston just removed cuz skip doesn't work on 1.8. Can you stick to just omitting the defined method completely?

@iainbeeston
Copy link
Contributor

Good point @pd. The problem with using skip is that

  1. For such a large number of tests it's very noisy ( and makes it hard to spot errors)
  2. It isn't supported on the test unit that comes with 1.8.7

I just (naively) pulled the skip condition up and out of the loop.

Otherwise this looks good!

@mpalmer
Copy link
Contributor Author

mpalmer commented Oct 30, 2014

Extra commit added to not define test methods for ignored tests. I added the skipping originally because @pd wanted it. I could make it skip on 1.9+ and not define on 1.8, if y'all can come to a consensus on whether skipping is desired behaviour or not.

@iainbeeston
Copy link
Contributor

My vote would be for not using skip, because it makes the test run incredibly noisy (not sure if there's a way to make test unit not print out all the details for every skipped test? because I agree that skip would be more correct than not running it)

@RST-J
Copy link
Contributor

RST-J commented Oct 30, 2014

I fully agree with @iainbeeston

pd added a commit that referenced this pull request Oct 30, 2014
Extend common-test-suite to ignore individual test cases
@pd pd merged commit 2823f55 into voxpupuli:master Oct 30, 2014
This was referenced Oct 30, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants