Add yajl, multi_json and uuidtools to travis #157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iainbeeston
changed the title
We have a few extra code paths that will only be activated if we use one of these gems. Adding them to the build matrix should cover those cases with all the tests in the regular test suite.
Previously travis was failing because it was looking for a gemspec in the gemfiles directory
iainbeeston
force-pushed
the
test_optional_gems
branch
from
d1a0b24 to
6f3fe0a
Compare
understand failures
By default it returns nil, but unfortunately json-schema expects failure to result in an exception. If nil is returned it's treated as a valid result and is used. In the case of initialize_data this is a problem because it overwrites the data passed in with nil
|
It turns out that yajl support is broken - it will parse strings that contain a json hash just fine, but if you pass it a string that does not parse, json-schema throws it away and tries to parse nil instead. Two of the common test suite tests picked this up (but I'm surprised it wasn't more than that) |
iainbeeston
force-pushed
the
test_optional_gems
branch
2 times, most recently
from
0af4076 to
35a828d
Compare
latest version of ruby Should make the build faster
iainbeeston
force-pushed
the
test_optional_gems
branch
from
35a828d to
7f5ed1c
Compare
|
👍, it's cool you got this down to fewer jobs than what it was earlier today =) |
|
👍 What a mess, thanks for taking these on @pd and @iainbeeston |
hoxworth
added a commit
that referenced
this pull request
Oct 28, 2014
Add yajl, multi_json and uuidtools to travis
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I discovered today that there are a few extra code paths that will only be activated if we use one of the following gems:
It's possible for json-schema to break when using some of those gems, but for the test suite to still pass. This pull request should fix that problem.