Unescape ref fragment pointers #146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `~0` and `~1` syntax are specified in the JSON Pointer draft: http://tools.ietf.org/html/draft-ietf-appsawg-json-pointer-07#section-3
|
Seems fine. |
|
👍 @RST-J There isn't a common practice right now, but I think there should be. While I have concerns that with few committers there will be instances where reviews can lag, I like having two sets of eyes on things as well before we merge into mainline. I'll update the |
hoxworth
added a commit
that referenced
this pull request
Oct 27, 2014
Unescape ref fragment pointers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
~0and~1syntax are specified in the JSON Pointer draft: http://tools.ietf.org/html/draft-ietf-appsawg-json-pointer-07#section-3The common suite tests
draft3/ref.jsonanddraft4/ref.jsonnow pass.