Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hyper validation #125

Merged
merged 5 commits into from
Oct 26, 2014
Merged

Hyper validation #125

merged 5 commits into from
Oct 26, 2014

Conversation

mpalmer
Copy link
Contributor

@mpalmer mpalmer commented Sep 21, 2014

Due to the fact that all the tests I added for this are in the JSON-Schema-Test-Suite submodule, this commit depends on my earlier work integrating that. If you're not keen on merging that previous work, let me know and I'll work up a new changeset with local tests.

This is good, because it's easier to debug a problem if you know *why*
there's a problem.
(Tests are part of the JSON-Schema-Test-Suite submodule; my PR hasn't been
merged upstream yet, though)

Given that I didn't actually need to change anything important to get the
validator to validate test schemas, I'm not entirely convinced that I've
done the right thing here -- or else the architecture of the validators is a
bit overengineered.
@pd
Copy link
Contributor

pd commented Oct 25, 2014

Just making a note to self to revisit this after merging #122.

@pd
Copy link
Contributor

pd commented Oct 26, 2014

@mpalmer can you rebase this to only include the hyperschema addition? Nevermind, git is smarter than I give it credit for. =)

pd added a commit that referenced this pull request Oct 26, 2014
@pd pd merged commit 8daf3de into voxpupuli:master Oct 26, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants