Gem::Specification::find_by_name errors #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hoxworth
added a commit
that referenced
this pull request
Jul 13, 2011
Gem::Specification::find_by_name errors
|
Thanks for this; I made the mistake of not testing out the Gem loading code after auto-merging some code recently. |
ottopoellath
pushed a commit
to ottopoellath/json-schema
that referenced
this pull request
May 24, 2013
Gem::Specification::find_by_name errors
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Gem::Specification::find_by_nameraisesGem::LoadErrorwhen it's unable to find required gem. So using this method in boolean statements requires one more rescue statement. You could easily see this issue by running gem tests on rubygems 1.8.5 without one of the optional gems installed: json, yajl-ruby or uuidtools.Checking gem availibality certainly needs a helper, I'm just not sure where to place it.
The patch in this request fixes the Gem::LoadError exception.