Handle non-latin uris #114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ruby's URI.parse does not accept non-latin characters, and will raise an error on any uri that is not completely in the latin alphabet. This is a problem for example, in japanese uris. I believe that the correct way to handle this in ruby is to escape the string before parsing it.
characters in the test files
|
@hoxworth Could you please take another look at this? Initially the build was failing because ruby 1.9 needed a file encoding comment, but I've fixed that now |
|
@iainbeeston This looks great, thanks! |
|
Released as part of 2.2.5 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ruby's URI.parse does not accept non-latin characters, and will raise an error on any uri that is not completely in the latin alphabet. This is a problem for example, in japanese uris.
I'm no expert on this, but when I googled around (eg. here) the correct way to handle it seems to be to escape the string before parsing.
I've added tests and updated the format attribute to escape uris before parsing them.