Fix for relative ref with fragment identifier on Windows #109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Any reason for not considering this? |
|
👍 I briefly used a friend's windows machine and was able to verify the bug and that this fixes test runs on windows. |
pd
added a commit
that referenced
this pull request
Oct 30, 2014
Fix for relative ref with fragment identifier on Windows
|
Sorry, I didn't really look at this until now. Can anyone explain what this is actually doing? I find it strange that it's a fix for relative schemas, but the actual change is outside of the I also can't help wondering if the real problem is with the URI::File class, and how that loads from a file (perhaps when URI::File opens a new file, should it remove the fragment at that point?) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Schemas like this won't work on Windows:
{ "$schema": "http://json-schema.org/draft-04/schema#", "properties": { "a": { "$ref": "definition_schema.json#/definitions/foo" } } }Relative links always have # appended. From what I can tell, since the path isn't in the format xxx://, it's passed on to Kernel#open as is - with the trailing #.
Adding chomp('#') fixes the issues. I don't see any problems causes by the addition. All tests pass(new ones added to test for relative refs with fragments) on Win and Linux.