Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Breaks with multi_json 1.7.9 (works with 1.7.7) #73

Closed
kylog opened this issue Sep 3, 2013 · 4 comments
Closed

Breaks with multi_json 1.7.9 (works with 1.7.7) #73

kylog opened this issue Sep 3, 2013 · 4 comments

Comments

@kylog
Copy link
Member

kylog commented Sep 3, 2013

With multi_json 1.7.9, running spec tests I get a backtrace like this:

/Users/kylo/devel/puppetk/.bundle/gems/ruby/1.8/gems/multi_json-1.7.9/lib/multi_json.rb:106:in `load_adapter': Did not recognize your adapter specification. (ArgumentError)
from /Users/kylo/devel/puppetk/.bundle/gems/ruby/1.8/gems/multi_json-1.7.9/lib/multi_json.rb:99:in `load_adapter'
from /Users/kylo/devel/puppetk/.bundle/gems/ruby/1.8/gems/multi_json-1.7.9/lib/multi_json.rb:89:in `use'
from /Users/kylo/devel/puppetk/.bundle/gems/ruby/1.8/gems/multi_json-1.7.9/lib/multi_json.rb:71:in `adapter'
from /Users/kylo/devel/puppetk/.bundle/gems/ruby/1.8/gems/json-schema-2.1.1/lib/json-schema.rb:14
@hoxworth
Copy link
Contributor

hoxworth commented Jan 2, 2014

Hey @kylog - I have been unable to reproduce this. I've tested on MRI 1.9.3-p484 / multi_json 1.7.9 with Oj / Yajl / JSON / bson individually, as well as JRuby 1.7.9 with JrJackson, which should cover all of the default adapters used by MultiJson. Could you share what JSON gems you are loading, or if you perform any multi_json initialization before loading the json-schema gem?

@kylog
Copy link
Member Author

kylog commented Jan 2, 2014

@hoxworth My bad, not enough details in the original report.

  • I only see this with 1.8.7-p371 (which is the only 1.8.7 I've tried; it may apply to 1.8.x).
  • I'm using the json backend, and I'm not doing any multi_json initialization.

E.g.

irb(main):001:0> RUBY_VERSION
=> "1.8.7"
irb(main):002:0> require 'json'
=> true
irb(main):003:0> require 'multi_json'
=> true
irb(main):004:0> require 'json-schema'
ArgumentError: Did not recognize your adapter specification.
    from /Users/kylo/devel/puppetk/.bundle/gems/ruby/1.8/gems/multi_json-1.8.2/lib/multi_json.rb:108:in `load_adapter'
    from /Users/kylo/devel/puppetk/.bundle/gems/ruby/1.8/gems/multi_json-1.8.2/lib/multi_json.rb:101:in `load_adapter'
    from /Users/kylo/devel/puppetk/.bundle/gems/ruby/1.8/gems/multi_json-1.8.2/lib/multi_json.rb:91:in `use'
    from /Users/kylo/devel/puppetk/.bundle/gems/ruby/1.8/gems/multi_json-1.8.2/lib/multi_json.rb:73:in `adapter'
    from /Users/kylo/devel/puppetk/.bundle/gems/ruby/1.8/gems/json-schema-2.1.6/lib/json-schema.rb:14`

@hoxworth
Copy link
Contributor

hoxworth commented Jan 2, 2014

Thanks! I'll clean this up tomorrow along with some other related fixes.

@iainbeeston
Copy link
Contributor

I'm assuming this is working now, partly based on @hoxworth's comments and partly because the test suit is now testing Ruby 1.8 (kind of) and multi_json

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@hoxworth @iainbeeston @kylog