Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

1.0.9 has ruby 1.9.x dependency; breaks patch compatibility #44

Closed
dekellum opened this issue Aug 31, 2012 · 1 comment
Closed

1.0.9 has ruby 1.9.x dependency; breaks patch compatibility #44

dekellum opened this issue Aug 31, 2012 · 1 comment

Comments

@dekellum
Copy link
Contributor

With 1.8 rubies:

undefined method `require_relative' for main:Object
json-schema-1.0.9/lib/json-schema/attributes/extends.rb:1:in `(root)'

Can find limited use of 1.9 require_relative here:

json-schema-1.0.9/lib/json-schema/attributes/extends.rb:require_relative 'ref'
json-schema-1.0.9/lib/json-schema/attributes/additionalproperties.rb:require_relative 'extends'

Where as if you really intend to go ruby 1.9 only then the gemspec should declare it and it shouldn't be introduced as 1.0.x patch release (buy normal community conventions.)
@hoxworth
Copy link
Contributor

hoxworth commented Jul 3, 2013

I believe this issue to now be resolved, and I will be careful to avoid breaking patch compatibility in the future. Closing this issue.

@hoxworth hoxworth closed this as completed Jul 3, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@hoxworth @dekellum