Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

additionalProperties and extends don't work together #31

Closed
japgolly opened this issue Mar 9, 2012 · 2 comments
Closed

additionalProperties and extends don't work together #31

japgolly opened this issue Mar 9, 2012 · 2 comments

Comments

@japgolly
Copy link
Contributor

japgolly commented Mar 9, 2012

Hey,

Hopefully I've got the schema wrong. I've tried 3 different ways of using extends and additionalProperties: false together and I just can't get it to work.

I committed a failing test case here:
japgolly@e4594a6

Looks like a bug to me. What do you think?
japgolly added a commit to japgolly/json-schema that referenced this issue Mar 12, 2012
@japgolly
AdditionalProperties:false now validates correctly when there are ext…
4acd728 
…ended properties. (Mostly fixes common case of issue voxpupuli#31)
@japgolly
Copy link
Contributor Author

Fixed the most common case on my branch:
https://github.com/japgolly/json-schema/tree/extends_and_additionalProperties_problem

So, case #1 - passes now
case #2 - fails but might be invalid, not sure
case #3 - still failing

@pd
Copy link
Contributor

pd commented Nov 4, 2014

It looks like these actually landed in master via #41 literally years ago, this was just never closed. =)

@pd pd closed this as completed Nov 4, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@pd @japgolly