Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop support for email and hostname formats #159

Closed
hoxworth opened this issue Oct 28, 2014 · 1 comment
Closed

Drop support for email and hostname formats #159

hoxworth opened this issue Oct 28, 2014 · 1 comment
Labels
Todo
Milestone
v3

Comments

@hoxworth
Copy link
Contributor

The email and hostname formats presently perform no validation action in this library; we should just outright remove them as "supported" formats, as validating against such a string is incredibly difficult.

Added to v3 milestone.
@hoxworth hoxworth added the Todo label Oct 28, 2014
@hoxworth hoxworth added this to the v3 milestone Oct 28, 2014
@pd
Copy link
Contributor

pd commented Nov 25, 2014

This actually didn't need to wait for 3.x, since it didn't break backwards compatibility in any way; they were just no-ops before. Fixed since #132.

@pd pd closed this as completed Nov 25, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Todo
Projects
None yet
Milestone
v3
Development

No branches or pull requests
2 participants
@pd @hoxworth