-
-
Notifications
You must be signed in to change notification settings - Fork 242
Comparing changes
Open a pull request
base repository: voxpupuli/json-schema
base: fa7776d
head repository: voxpupuli/json-schema
compare: 597952b
- 19 commits
- 30 files changed
- 6 contributors
Commits on Mar 6, 2015
-
There are a lot of places in the code where we rescue any error, at all. That's quite dangerous, as it could conceal bugs. I've changed it so that we always specify which error class we want to catch. Mostly it's been a minor change, but there are two API changes: * When it comes to loading data I've had to introduce an explicit list of protocols which we can load json over (otherwise it's possible to have a uri with a scheme that makes no sense - it'd still be a valid uri but loading from it is impossible). I've used the list of protocols that addressable recognizes for now. * No matter what JSON parser you use, we now always raise a JSON::Schema::JsonParseError. Without doing this it would be tricky to handle parser errors identically, for all parsers (the other option would be to catch a long list of potential parse errors, but this seems more sensible).
Configuration menu - View commit details
-
Copy full SHA for cb52269 - Browse repository at this point
Copy the full SHA cb52269View commit details
Commits on Nov 2, 2015
-
Configuration menu - View commit details
-
Copy full SHA for 710b6f2 - Browse repository at this point
Copy the full SHA 710b6f2View commit details
Commits on Nov 24, 2015
-
Test all versions in test_custom_format
James McKinney committedNov 24, 2015 Configuration menu - View commit details
-
Copy full SHA for 5b80c53 - Browse repository at this point
Copy the full SHA 5b80c53View commit details
Commits on Dec 22, 2015
-
Merge pull request #278 from jpmckinney/register_format_validator
Test all versions in test_custom_format
Configuration menu - View commit details
-
Copy full SHA for d14e51b - Browse repository at this point
Copy the full SHA d14e51bView commit details -
Iain Beeston committed
Dec 22, 2015 Configuration menu - View commit details
-
Copy full SHA for 0d26205 - Browse repository at this point
Copy the full SHA 0d26205View commit details
Commits on Dec 23, 2015
-
Merge pull request #271 from mkonecny/master
Update README.textile to fix schema validation example
Configuration menu - View commit details
-
Copy full SHA for d52160e - Browse repository at this point
Copy the full SHA d52160eView commit details -
Iain Beeston committed
Dec 23, 2015 Configuration menu - View commit details
-
Copy full SHA for 31a620b - Browse repository at this point
Copy the full SHA 31a620bView commit details -
Merge pull request #239 from iainbeeston/rescue-explicit-errors
Only rescue errors explicitly
Configuration menu - View commit details
-
Copy full SHA for 9de1347 - Browse repository at this point
Copy the full SHA 9de1347View commit details
Commits on Dec 24, 2015
-
Speed up JSON::Validator.validate
Addressible's URI parsing shows up at the top of the profiler for our use case. This patch adds a cache to JSON::Util::URI.normalized_uri, to trade CPU time for memory. There are other expensive Addressible methods that should be cached elsewhere. benchmark: https://github.com/mjc/json-schema-perf MRI 2.2.2 before: 825.363 (± 6.2%) i/s MRI 2.2.2 after: 1.436k (± 4.5%) i/s 1.74x faster JRuby 1.7.20 before: 1.445k (± 2.5%) i/s JRuby 1.7.20 after: 2.272k (± 6.1%) i/s 1.57x faster
Configuration menu - View commit details
-
Copy full SHA for d898905 - Browse repository at this point
Copy the full SHA d898905View commit details -
Configuration menu - View commit details
-
Copy full SHA for 46abf88 - Browse repository at this point
Copy the full SHA 46abf88View commit details -
Don't update url fragment if it's already blank or nil
Addressable::URI#fragment= triggers a revalidation of the URL, which is super slow. Don't do this when it isn't necessary.
Iain Beeston committedDec 24, 2015 Configuration menu - View commit details
-
Copy full SHA for ba16939 - Browse repository at this point
Copy the full SHA ba16939View commit details -
Removed all references to Addressable outside JSON::Util::URI
Hopefully this will make it easier to change in future
Iain Beeston committedDec 24, 2015 Configuration menu - View commit details
-
Copy full SHA for 6967d99 - Browse repository at this point
Copy the full SHA 6967d99View commit details
Commits on Jan 4, 2016
-
Configuration menu - View commit details
-
Copy full SHA for 111f16e - Browse repository at this point
Copy the full SHA 111f16eView commit details
Commits on Jan 8, 2016
-
Merge pull request #286 from teoljungberg/patch-1
Remove ruby warnings
Configuration menu - View commit details
-
Copy full SHA for 4744d41 - Browse repository at this point
Copy the full SHA 4744d41View commit details -
Merge pull request #285 from iainbeeston/cache-normalized-uri
Redux: speed up JSON::Validator.validate
Configuration menu - View commit details
-
Copy full SHA for 6a1620e - Browse repository at this point
Copy the full SHA 6a1620eView commit details -
Iain Beeston committed
Jan 8, 2016 Configuration menu - View commit details
-
Copy full SHA for da77b70 - Browse repository at this point
Copy the full SHA da77b70View commit details -
Added ruby 2.3 to the travis build
Iain Beeston committedJan 8, 2016 Configuration menu - View commit details
-
Copy full SHA for f4183cf - Browse repository at this point
Copy the full SHA f4183cfView commit details -
Corrected ruby 2.3 build on travis
Iain Beeston committedJan 8, 2016 Configuration menu - View commit details
-
Copy full SHA for 0dc3510 - Browse repository at this point
Copy the full SHA 0dc3510View commit details -
Iain Beeston committed
Jan 8, 2016 Configuration menu - View commit details
-
Copy full SHA for 597952b - Browse repository at this point
Copy the full SHA 597952bView commit details
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff fa7776d...597952b