Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: voxpupuli/json-schema
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: fa7776d
Choose a base ref
...
head repository: voxpupuli/json-schema
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 597952b
Choose a head ref
  • 19 commits
  • 30 files changed
  • 6 contributors

Commits on Mar 6, 2015

  1. Only rescue errors explicitly

    There are a lot of places in the code where we rescue any error, at all.
    That's quite dangerous, as it could conceal bugs.
    
    I've changed it so that we always specify which error class we want to
    catch. Mostly it's been a minor change, but there are two API changes:
    
    * When it comes to loading data I've had to introduce an explicit list
      of protocols which we can load json over (otherwise it's possible to
      have a uri with a scheme that makes no sense - it'd still be a valid
      uri but loading from it is impossible). I've used the list of
      protocols that addressable recognizes for now.
    * No matter what JSON parser you use, we now always raise a
      JSON::Schema::JsonParseError. Without doing this it would be tricky to
      handle parser errors identically, for all parsers (the other option
      would be to catch a long list of potential parse errors, but this
      seems more sensible).
    iainbeeston committed Mar 6, 2015
    Configuration menu
    Copy the full SHA
    cb52269 View commit details
    Browse the repository at this point in the history

Commits on Nov 2, 2015

  1. Update README.textile

    mkonecny committed Nov 2, 2015
    Configuration menu
    Copy the full SHA
    710b6f2 View commit details
    Browse the repository at this point in the history

Commits on Nov 24, 2015

  1. Test all versions in test_custom_format

    James McKinney committed Nov 24, 2015
    Configuration menu
    Copy the full SHA
    5b80c53 View commit details
    Browse the repository at this point in the history

Commits on Dec 22, 2015

  1. Merge pull request #278 from jpmckinney/register_format_validator

    Test all versions in test_custom_format
    iainbeeston committed Dec 22, 2015
    Configuration menu
    Copy the full SHA
    d14e51b View commit details
    Browse the repository at this point in the history
  2. Updated common test suite

    Iain Beeston committed Dec 22, 2015
    Configuration menu
    Copy the full SHA
    0d26205 View commit details
    Browse the repository at this point in the history

Commits on Dec 23, 2015

  1. Merge pull request #271 from mkonecny/master

    Update README.textile to fix schema validation example
    iainbeeston committed Dec 23, 2015
    Configuration menu
    Copy the full SHA
    d52160e View commit details
    Browse the repository at this point in the history
  2. Added a changelog

    Iain Beeston committed Dec 23, 2015
    Configuration menu
    Copy the full SHA
    31a620b View commit details
    Browse the repository at this point in the history
  3. Merge pull request #239 from iainbeeston/rescue-explicit-errors

    Only rescue errors explicitly
    iainbeeston committed Dec 23, 2015
    Configuration menu
    Copy the full SHA
    9de1347 View commit details
    Browse the repository at this point in the history

Commits on Dec 24, 2015

  1. Speed up JSON::Validator.validate

    Addressible's URI parsing shows up at the top of the profiler for our use case.
    
    This patch adds a cache to JSON::Util::URI.normalized_uri, to trade CPU time for memory.
    
    There are other expensive Addressible methods that should be cached elsewhere.
    
    benchmark: https://github.com/mjc/json-schema-perf
    
    MRI 2.2.2 before: 825.363  (± 6.2%) i/s
    MRI 2.2.2 after:  1.436k (± 4.5%) i/s
    
    1.74x faster
    
    JRuby 1.7.20 before: 1.445k (± 2.5%) i/s
    JRuby 1.7.20 after: 2.272k (± 6.1%) i/s
    
    1.57x faster
    mjc authored and Iain Beeston committed Dec 24, 2015
    Configuration menu
    Copy the full SHA
    d898905 View commit details
    Browse the repository at this point in the history
  2. Don't use YAML when JSON.dump will do

    mjc authored and Iain Beeston committed Dec 24, 2015
    Configuration menu
    Copy the full SHA
    46abf88 View commit details
    Browse the repository at this point in the history
  3. Don't update url fragment if it's already blank or nil

    Addressable::URI#fragment= triggers a revalidation of the URL, which is
    super slow.  Don't do this when it isn't necessary.
    Iain Beeston committed Dec 24, 2015
    Configuration menu
    Copy the full SHA
    ba16939 View commit details
    Browse the repository at this point in the history
  4. Removed all references to Addressable outside JSON::Util::URI

    Hopefully this will make it easier to change in future
    Iain Beeston committed Dec 24, 2015
    Configuration menu
    Copy the full SHA
    6967d99 View commit details
    Browse the repository at this point in the history

Commits on Jan 4, 2016

  1. Remove ruby warnings

    For the unused variable `validator`
    teoljungberg committed Jan 4, 2016
    Configuration menu
    Copy the full SHA
    111f16e View commit details
    Browse the repository at this point in the history

Commits on Jan 8, 2016

  1. Merge pull request #286 from teoljungberg/patch-1

    Remove ruby warnings
    iainbeeston committed Jan 8, 2016
    Configuration menu
    Copy the full SHA
    4744d41 View commit details
    Browse the repository at this point in the history
  2. Merge pull request #285 from iainbeeston/cache-normalized-uri

    Redux: speed up JSON::Validator.validate
    iainbeeston committed Jan 8, 2016
    Configuration menu
    Copy the full SHA
    6a1620e View commit details
    Browse the repository at this point in the history
  3. Updated common test suite

    Iain Beeston committed Jan 8, 2016
    Configuration menu
    Copy the full SHA
    da77b70 View commit details
    Browse the repository at this point in the history
  4. Added ruby 2.3 to the travis build

    Iain Beeston committed Jan 8, 2016
    Configuration menu
    Copy the full SHA
    f4183cf View commit details
    Browse the repository at this point in the history
  5. Corrected ruby 2.3 build on travis

    Iain Beeston committed Jan 8, 2016
    Configuration menu
    Copy the full SHA
    0dc3510 View commit details
    Browse the repository at this point in the history
  6. Bumped version to 2.6.0

    Iain Beeston committed Jan 8, 2016
    Configuration menu
    Copy the full SHA
    597952b View commit details
    Browse the repository at this point in the history
Loading