(BKR-1168) Exit early on --version, --help, and --parse-only #1523
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Those failures are the continued Windows cURL issues. Everything else is good. |
|
Jenkins, test this please |
1 similar comment
|
Jenkins, test this please |
|
Pending removal of further early-exit conditions based on |
|
Jenkins, retest this please. |
Previous "dry-run"-esque behavior was leaky, resulting in a not-so-dry run. - Subcommand spec tests for exec should not actually call cli.execute!, so intercept them. - Process all early-exit flags first
|
Jenkins, retest this please. |
|
@kevpl Tests are all pass except for a transient package error on Solaris. |
kevpl
previously requested changes
Jun 20, 2018
CHANGELOG.md
Outdated
| @@ -19,6 +19,7 @@ git logs & PR history. | |||
|
|
|||
| - Raise `ArgumentError` when passing `role = nil` to `only_host_with_role()` or `find_at_most_one_host_with_role()` | |||
| - Use `install_package_with_rpm` in `add_el_extras` | |||
| - Exit early on --help/--version/--parse-only arguments instead of partial dry-run | |||
There was a problem hiding this comment.
looks like this line has been pushed down into 3.36.0 with the new release, so this will have to be put back up into the Unreleased section
|
looks like a vmpooler provisioning issue, will rekick. Jenkins, test this please |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, some code paths could allow continued execution of Beaker after encountering these flags. This resulted in a not-so-dry run scenario which, at best, caused confusing error output when
beaker --versionwas called and, at worst, may have led to the unintentional execution of a configured provisioning task.