Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proxy URL #4011

Merged
merged 3 commits into from
Jan 16, 2024
Merged

Proxy URL #4011

merged 3 commits into from
Jan 16, 2024

Conversation

benjaminpkane
Copy link
Contributor

Clone of #4009 targeting release/v0.23.3

@benjaminpkane benjaminpkane self-assigned this Jan 16, 2024
Copy link
Contributor

@sashankaryal sashankaryal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

Copy link

codecov bot commented Jan 16, 2024

Codecov Report

Attention: 22 lines in your changes are missing coverage. Please review.

Comparison is base (d2e1fbf) 15.92% compared to head (6331d5a) 15.99%.
Report is 15 commits behind head on release/v0.23.3.

Files Patch % Lines
app/packages/looker/src/zoom.ts 6.25% 15 Missing ⚠️
app/packages/app/src/useEventSource.ts 0.00% 4 Missing ⚠️
app/packages/looker/src/util.ts 33.33% 2 Missing ⚠️
app/packages/looker/src/overlays/index.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@                 Coverage Diff                 @@
##           release/v0.23.3    #4011      +/-   ##
===================================================
+ Coverage            15.92%   15.99%   +0.07%     
===================================================
  Files                  732      732              
  Lines                81926    81962      +36     
  Branches              1093     1101       +8     
===================================================
+ Hits                 13045    13113      +68     
+ Misses               68881    68849      -32     
Flag Coverage Δ
app 15.99% <26.66%> (+0.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@benjaminpkane benjaminpkane merged commit 1acecfb into release/v0.23.3 Jan 16, 2024
32 of 37 checks passed
@benjaminpkane benjaminpkane deleted the bug/app-proxy branch January 16, 2024 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants